swamirishi commented on code in PR #5165:
URL: https://github.com/apache/ozone/pull/5165#discussion_r1290923949


##########
hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/NativeLibraryLoader.java:
##########
@@ -139,7 +139,7 @@ private Optional<File> copyResourceFromJarToTemp(final 
String libraryName)
       // create a temporary file to copy the library to
       final File temp = File.createTempFile(libraryName, getLibOsSuffix(),
           new File(Optional.ofNullable(System.getProperty(NATIVE_LIB_TMP_DIR))
-              .orElse("")));
+              .orElse("")).getAbsoluteFile());

Review Comment:
   yeah. When parent has path empty. It resorts to fs.defaultParent() which is 
"/" so the test case fails with no permission on "/" to create a temp file.
   
https://github.com/bpupadhyaya/openjdk-8/blob/45af329463a45955ea2759b89cb0ebfe40570c3f/jdk/src/share/classes/java/io/File.java#L363



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to