swamirishi commented on code in PR #5165:
URL: https://github.com/apache/ozone/pull/5165#discussion_r1290931358
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java:
##########
@@ -58,7 +62,7 @@ class TestManagedSstFileReader {
// Key prefix containing all characters, to check if all characters can be
// written & read from rocksdb through SSTDumptool
- private static final String KEY_PREFIX = IntStream.range(0, 256).boxed()
+ private static final String KEY_PREFIX = IntStream.range(1, 256).boxed()
Review Comment:
As part of the bounds we pass utf-8 strings. So string containing '\0' does
not have the same value when encode UTF-8 on java which is 0. But in jni the
utf-8 encoded value for '\0' becomes -64 -128. Thus the value becomes
different. In order to support this, I have made the change on the rocks-tools
to pass the address of the ManagedSlice we can use the object of the slice
directly from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
