swamirishi commented on code in PR #5165:
URL: https://github.com/apache/ozone/pull/5165#discussion_r1290926036
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSstFileReader.java:
##########
@@ -89,6 +90,11 @@ public long getEstimatedTotalKeys() throws RocksDBException {
}
public Stream<String> getKeyStream() throws RocksDBException {
+ return getKeyStream(Optional.empty(), Optional.empty());
+ }
Review Comment:
yeah. It is being tested with this testcase we pass Optional.empty() for
both lower bound and upper bound in one of the combination since
Optional.empty() is part of the testBound list.
https://github.com/apache/ozone/blob/13da8647d368b5d2a17857d3535d72c772801f3e/hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java#L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
