sodonnel commented on code in PR #5604:
URL: https://github.com/apache/ozone/pull/5604#discussion_r1400542675
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java:
##########
@@ -535,9 +548,11 @@ public void closeStalePipelines(DatanodeDetails
datanodeDetails) {
pipelinesWithStaleIpOrHostname.size());
pipelinesWithStaleIpOrHostname.forEach(p -> {
try {
- LOG.info("Closing the stale pipeline: {}", p.getId());
- closePipeline(p, false);
- LOG.info("Closed the stale pipeline: {}", p.getId());
+ final PipelineID id = p.getId();
+ LOG.info("Closing the stale pipeline: {}", id);
Review Comment:
Nit: I am not sure we need this log message. We have a message below for
"closed" and then exception handler has a message for "failed to close".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
