sodonnel commented on code in PR #5604:
URL: https://github.com/apache/ozone/pull/5604#discussion_r1400760489
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -140,6 +143,10 @@ public Instant getCreationTimestamp() {
return creationTimestamp;
}
+ public Instant getStateEnterTime() {
Review Comment:
Ah, I missed that the builder sets creation time. I guess this is OK as the
constructor is private, so the only way to create the object is via the builder.
I noticed that the setter is public:
```
public void setCreationTimestamp(Instant creationTimestamp) {
this.creationTimestamp = creationTimestamp;
}
```
We could make that private as the inner Builder class can call the private
methods. This is not really in scope for this PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
