sodonnel commented on code in PR #5604:
URL: https://github.com/apache/ozone/pull/5604#discussion_r1400552647
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -140,6 +143,10 @@ public Instant getCreationTimestamp() {
return creationTimestamp;
}
+ public Instant getStateEnterTime() {
Review Comment:
Yeah, it is a little strange that creationTime and stateEnterTime are both
basically hardcoded to "now". Feels like we should only need one of them, as
creation time isn't really "correct". If the pipeline changes state from open
to closed, the creation time is going to change too, due to its immutable
nature. I can see how this could be confusing to someone in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
