nandakumar131 commented on code in PR #5604:
URL: https://github.com/apache/ozone/pull/5604#discussion_r1400659515
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -140,6 +143,10 @@ public Instant getCreationTimestamp() {
return creationTimestamp;
}
+ public Instant getStateEnterTime() {
Review Comment:
@sodonnel, I completely understand the confusion here. We should refactor
the code for better understandability.
Currently we don't have any functional issues as we update the creation time
in the builder while we create the Pipeline object from existing pipeline
reference.
If you look at `Pipeline$Builder(Pipeline pipeline)`, it assigns the
creation time from the given pipeline reference.
With the current code, it's easy to introduce bugs in future. We should
re-write the `Pipeline` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
