szetszwo commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416264248
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , thanks for pointing out [comment-Jun 15,
2020](https://github.com/apache/ozone/pull/921#issuecomment-638231484).
Indeed, that comment did not veto it. The veto comment was [comment-Jun 14,
2020](https://github.com/apache/ozone/pull/921#issuecomment-643829659), which
was based on
- https://accessibility.digital.gov/visual-design/typography/
It seems irrelevant since it talks about **textual information** but not
computer code. It also says
> ... Don’t make lines too long or too short: 45-75 characters per line ...
Are we going to enforce min line length 45?
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , thanks for pointing out [comment-Jun 15,
2020](https://github.com/apache/ozone/pull/921#issuecomment-638231484).
Indeed, that comment did not veto it. The veto comment was [comment-Jun 14,
2020](https://github.com/apache/ozone/pull/921#issuecomment-643829659), which
was based on
- https://accessibility.digital.gov/visual-design/typography/
It seems irrelevant since it talks about **textual information** but not
computer code. It also says
> ... Don’t make lines too long or too short: 45-75 characters per line ...
Are we going to enforce min line length 45?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
