ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416734649
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
Well I don't want to be the bad guy blocking you folks for something I don't
consider a problem(code wise).
But this is gonna set an example, so for posterity when this is used as an
example by some other people(or me) to say a veto can be overruled by 1 or 2
people(coincidently from same org) on a PR itself in Ozone by stating the
reason is invalid, which wasn't actually of 1+1=2 type, it was an accepted
activity then, but I was in no way in favour of that. The other people didn't
respect the ByLaws.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
