ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416313457
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
Just speaking about the process:
If you read the hadoop by laws as well
https://hadoop.apache.org/bylaws.html
> The validity of a veto, if challenged, can be confirmed by anyone who has
a binding vote. This does not necessarily signify agreement with the veto -
merely that the veto is valid.
Means that veto is valid only, Anu is a committer & he gave a reason, we are
not convinced that doesn't make that invalid. This my understanding, & I have
never seen a veto getting overruled, I maybe missing some catch there. Maybe we
can relaunch that existing mail thread & someone with more insights on the
process can help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
