ayushtkn commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416292909
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
I personally don't have any issue with this change, a lot of projects have
120 as the limit(ex. hive)
But from the process point of view it isn't allowed by Apache ByLaws
https://www.apache.org/foundation/voting.html#votes-on-code-modification
It reads
``
but -1 votes are vetos and kill the proposal dead until all vetoers withdraw
their -1 votes.
``
Regarding the veto
https://www.apache.org/foundation/voting.html#Veto
``
A -1 vote by a qualified voter stops a code-modification proposal in its
tracks. This constitutes a veto, and it cannot be overruled nor overridden by
anyone. Vetoes stand until and unless the individual withdraws their veto.
``
So, by this unless @anuengineer doesn't withdraw his veto, his vote can not
be overruled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
