szetszwo commented on code in PR #5737:
URL: https://github.com/apache/ozone/pull/5737#discussion_r1416825700
##########
hadoop-hdds/dev-support/checkstyle/checkstyle.xml:
##########
@@ -73,6 +73,7 @@
<module name="LineLength">
<property name="fileExtensions" value="java"/>
+ <property name="max" value="120"/>
Review Comment:
@ayushtkn , I understand you concern -- I did mention explicitly in
https://github.com/apache/ozone/pull/921#issuecomment-1841610769 that the veto
should be considered as invalid. The veto is actually similar to 1+1=2 type --
45-75 line length is good for `textual information` but it definitely is not
good for computer programs. It is nonsense to enforce min line length in
computer programs. It is also nonsense to enforce 75 max line length. How
could it be valid?
On the other hands, short line length such as 80 does lead to many problems
-- code readability, encouraging short variable names, unnecessary code
formatting efforts, etc. All these problems were not considered in the
`textual information` recommandation.
Thanks for bring it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
