xBis7 commented on code in PR #5651:
URL: https://github.com/apache/ozone/pull/5651#discussion_r1425201711
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthStatus.java:
##########
@@ -87,19 +117,19 @@ public boolean isDeleted() {
}
public boolean isOverReplicated() {
- return replicaDelta < 0;
+ return containerReplicaCount.isOverReplicated();
}
public boolean isUnderReplicated() {
- return !isMissing() && replicaDelta > 0;
+ return !isMissing() && containerReplicaCount.isUnderReplicated();
Review Comment:
@sodonnel By removing `isUnderReplicated()` from the interface, this should
be
```suggestion
return !isMissing() && !containerReplicaCount.isSufficientlyReplicated();
```
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
