sodonnel commented on code in PR #5651:
URL: https://github.com/apache/ozone/pull/5651#discussion_r1425186208
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthStatus.java:
##########
@@ -78,6 +100,14 @@ public int getReplicationFactor() {
}
public boolean isHealthy() {
+ return containerReplicaCount.isHealthy();
Review Comment:
This is changing the meaning here. RepCount isHealthy is checking for the
container being closed / quasi-closed and all replicas match that. The original
isHealthy here was about not under / over rep and also not mis-rep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
