xBis7 commented on code in PR #5651:
URL: https://github.com/apache/ozone/pull/5651#discussion_r1425198642
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthStatus.java:
##########
@@ -78,6 +100,14 @@ public int getReplicationFactor() {
}
public boolean isHealthy() {
+ return containerReplicaCount.isHealthy();
Review Comment:
I know, that's why I renamed the original method to `isProperlyReplicated()`
and now every method in Recon, calling `isHealthy()`, now calls
`isProperlyReplicated()`.
It's part of the problem, that Recon uses the same method naming as the SCM
but has a different meaning for most of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
