sodonnel commented on code in PR #5651:
URL: https://github.com/apache/ozone/pull/5651#discussion_r1425183102
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaCount.java:
##########
@@ -49,6 +49,8 @@ public interface ContainerReplicaCount {
boolean isSufficientlyReplicatedForOffline(DatanodeDetails datanode,
NodeManager nodeManager);
+ boolean isUnderReplicated();
Review Comment:
I am not sure we really need another method on the interface which is just
`!isSufficientlyReplicated()` - we can just call `!isSufficientlyReplicated()`
without adding more to the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
