jojochuang commented on code in PR #5847:
URL: https://github.com/apache/ozone/pull/5847#discussion_r1440926009
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/Statistic.java:
##########
@@ -79,6 +79,7 @@ public enum Statistic {
"Calls of isFileClosed()"),
INVOCATION_RECOVER_LEASE("op_recover_lease",
"Calls of recoverLease()"),
+ INVOCATION_COMMIT("op_commit", "Calls of commit()"),
Review Comment:
should it be called INVOCATION_RECOVER_FILE instead?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java:
##########
@@ -102,17 +104,17 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
OMClientResponse omClientResponse = null;
boolean bucketLockAcquired = false;
Result result;
- boolean isHSync = commitKeyRequest.hasHsync() &&
- commitKeyRequest.getHsync();
-
- if (isHSync) {
+ boolean isHSync = commitKeyRequest.hasHsync() &&
commitKeyRequest.getHsync();
Review Comment:
a little more comments to explain the three booleans would be great to help
someone else without the context to understand better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
