ChenSammi commented on code in PR #5847:
URL: https://github.com/apache/ozone/pull/5847#discussion_r1442419742
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestLeaseRecovery.java:
##########
@@ -149,8 +149,7 @@ public void testRecovery() throws Exception {
Thread.sleep(1000);
}
// The lease should have been recovered.
- assertTrue("File should be closed", fs.recoverLease(file));
Review Comment:
Yes, the second call of recoverLease will fail if the first has succeeded,
since the file is already committed so checks in OM side will fail. Should we
keep the same behavior as HDFS? I remember @szetszwo has mentioned a case that
if after a Hbase region server fails, two new Hbase region servers start on the
server, if the second region server calls recoverLease and gets a successful
result, then there could be two region servers started and running on the same
server. Not sure if Hbase has other checks to prevent the second region server
to start so that the two region servers running altogether will not happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
