ashishkumar50 commented on code in PR #6033:
URL: https://github.com/apache/ozone/pull/6033#discussion_r1461744690


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMRecoverLeaseRequest.java:
##########
@@ -269,7 +269,9 @@ private RecoverLeaseResponse doWork(OzoneManager 
ozoneManager,
     // refresh last block pipeline
     ContainerWithPipeline containerWithPipeline =
         
ozoneManager.getScmClient().getContainerClient().getContainerWithPipeline(finalBlock.getContainerID());
-    finalBlock.setPipeline(containerWithPipeline.getPipeline());
+    if (containerWithPipeline != null) {

Review Comment:
   If 
[ignorePipeline](https://github.com/apache/ozone/blob/37213b7085be08721934161d8102f09f7671d0b4/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java#L72)
 is true, `keyTable/openKeyTable` doesn't store pipeline info. And hence after 
fetching from db it returns null. Looks like this will impact leaseRecovery if 
pipeline info is not stored.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to