ChenSammi commented on code in PR #6033:
URL: https://github.com/apache/ozone/pull/6033#discussion_r1463002733
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1882,10 +1885,12 @@ public ExpiredOpenKeys getExpiredOpenKeys(Duration
expireThreshold,
.filter(id -> id.equals(clientIdString))
.isPresent();
- if (!isHsync) {
+ if (!isHsync && openKeyInfo.getCreationTime() <=
expiredCreationTimestamp) {
// add non-hsync'ed keys
expiredKeys.addOpenKey(openKeyInfo, dbOpenKeyName);
- } else {
+ num++;
+ } else if (isHsync && openKeyInfo.getModificationTime() <=
expiredLeaseTimestamp &&
+
!openKeyInfo.getMetadata().containsKey(OzoneConsts.LEASE_RECOVERY)) {
Review Comment:
Yes. If the manual recovery client crashes before the final file commit,
then this file will be kept in the openKeyTable. User can rerun the manual
recovery through CLI again to recover the file later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
