ashishkumar50 commented on code in PR #6033:
URL: https://github.com/apache/ozone/pull/6033#discussion_r1462939701
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1882,10 +1885,12 @@ public ExpiredOpenKeys getExpiredOpenKeys(Duration
expireThreshold,
.filter(id -> id.equals(clientIdString))
.isPresent();
- if (!isHsync) {
+ if (!isHsync && openKeyInfo.getCreationTime() <=
expiredCreationTimestamp) {
// add non-hsync'ed keys
expiredKeys.addOpenKey(openKeyInfo, dbOpenKeyName);
- } else {
+ num++;
+ } else if (isHsync && openKeyInfo.getModificationTime() <=
expiredLeaseTimestamp &&
+
!openKeyInfo.getMetadata().containsKey(OzoneConsts.LEASE_RECOVERY)) {
Review Comment:
When manual recovery is performed on a file we are skipping those file for
auto recovery. These file can be manually recovered any time. We are skipping
this to avoid any data loss in this case as the exact length may not get
updated during auto recovery.
@ChenSammi can you please help to confirm if we can remove this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
