smengcl commented on code in PR #6033:
URL: https://github.com/apache/ozone/pull/6033#discussion_r1462638683
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1439,6 +1439,17 @@
</description>
</property>
+ <property>
+ <name>ozone.om.lease.hard.limit</name>
+ <value>7d</value>
+ <tag>OZONE, OM, PERFORMANCE</tag>
+ <description>
+ Controls how long an open hsync key is considered as active.
Specifically, if a hsync key
+ has been open longer than the value of this config entry, that open
hsync key is considered as
+ expired (e.g. due to client crash). Unit could be defined with postfix
(ns,ms,s,m,h,d)
Review Comment:
What happens if an admin misconfigures this to `7ms`? A key will almost
immediately get committed after a client calls `hsync()` if that
`OpenKeyCleanupService` is triggered at that moment?
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1439,6 +1439,17 @@
</description>
</property>
+ <property>
+ <name>ozone.om.lease.hard.limit</name>
+ <value>7d</value>
+ <tag>OZONE, OM, PERFORMANCE</tag>
+ <description>
+ Controls how long an open hsync key is considered as active.
Specifically, if a hsync key
+ has been open longer than the value of this config entry, that open
hsync key is considered as
+ expired (e.g. due to client crash). Unit could be defined with postfix
(ns,ms,s,m,h,d)
Review Comment:
What happens if an admin misconfigures this to `7ms`? A key will almost
immediately get committed after a client calls `hsync()` if
`OpenKeyCleanupService` is triggered at that moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
