kerneltime commented on code in PR #6341:
URL: https://github.com/apache/ozone/pull/6341#discussion_r1514987076
##########
hadoop-hdds/rocks-native/src/CMakeLists.txt:
##########
@@ -22,8 +22,8 @@
cmake_minimum_required(VERSION 2.8)
add_definitions(-D_GLIBCXX_USE_CXX11_ABI=0)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
Review Comment:
Why no optimization at all? This is different that specifying the
instruction sets. Can you look into `add_compile_options(-msse2) ` ? I am not
sure no optimization == chipset instructions to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
