smengcl commented on PR #6341: URL: https://github.com/apache/ozone/pull/6341#issuecomment-2010879068
> > @swamirishi we can merge this in once you specify the testing done for this. > > I tested out this particular patch by building the code in an environment which supports avx2. I built the shared library and tried to load the library on another machine which doesn't support this instruction set without the flag PORTABLE=1 and with the flag PORTABLE=1. The library load failed with the error in the first run: > > <img alt="Screen Shot 2024-03-20 at 15 15 19" width="856" src="https://private-user-images.githubusercontent.com/47532440/314694209-3132f5f0-17b6-4105-833c-76e09dc5e49f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA5NzYyNjMsIm5iZiI6MTcxMDk3NTk2MywicGF0aCI6Ii80NzUzMjQ0MC8zMTQ2OTQyMDktMzEzMmY1ZjAtMTdiNi00MTA1LTgzM2MtNzZlMDlkYzVlNDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzIwVDIzMDYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwNWZlOGM0YTI1NzQ4MzI4MDIxMzJhZTYxOTQ2YmZjODg4YzBjMzMxYmY5MDJmOWQ1Zjg2NzRjZWM3YmIyMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bHgcArud9_06qCMH_vMyU6bmudP_VGshGIJwyxsI568";> > The second time the load succeeded. Yup fyi `PORTABLE` flag is used here in `CMakeLists.txt` to disable avx/avx2 optimizations here: https://github.com/facebook/rocksdb/blob/v7.7.3/CMakeLists.txt#L252-L277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/47532440/314694209-3132f5f0-17b6-4105-833c-76e09dc5e49f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA5NzYyNjMsIm5iZiI6MTcxMDk3NTk2MywicGF0aCI6Ii80NzUzMjQ0MC8zMTQ2OTQyMDktMzEzMmY1ZjAtMTdiNi00MTA1LTgzM2MtNzZlMDlkYzVlNDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzIwVDIzMDYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwNWZlOGM0YTI1NzQ4MzI4MDIxMzJhZTYxOTQ2YmZjODg4YzBjMzMxYmY5MDJmOWQ1Zjg2NzRjZWM3YmIyMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bHgcArud9_06qCMH_vMyU6bmudP_VGshGIJwyxsI568"](https://private-user-images.githubusercontent.com/47532440/314694209-3132f5f0-17b6-4105-833c-76e09dc5e49f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA5NzYyNjMsIm5iZiI6MTcxMDk3NTk2MywicGF0aCI6Ii80NzUzMjQ0MC8zMTQ2OTQyMDktMzEzMmY1ZjAtMTdiNi00MTA1LTgzM2MtNzZlMDlkYzVlNDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzIwVDIzMDYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwNWZlOGM0YTI1NzQ4MzI4MDIxMzJhZTYxOTQ2YmZjODg4YzBjMzMxYmY5MDJmOWQ1Zjg2NzRjZWM3YmIyMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bHgcArud9_06qCMH_vMyU6bmudP_VGshGIJwyxsI568"){kind=link}