smengcl commented on code in PR #6341:
URL: https://github.com/apache/ozone/pull/6341#discussion_r1533037305


##########
hadoop-hdds/rocks-native/pom.xml:
##########
@@ -235,6 +235,7 @@
                       <arg 
line="${project.build.directory}/rocksdb/rocksdb-${rocksdb.version}"/>
                     </exec>
                     <exec executable="make" 
dir="${project.build.directory}/rocksdb/rocksdb-${rocksdb.version}" 
failonerror="true">
+                      <arg line="PORTABLE=1"/>

Review Comment:
   The `.so` from the publicly distributed `rocksdbjni-7.7.3.jar` doesn't seem 
to be AVX or AVX2 optimized:
   
   ```bash
   $ elfx86exts librocksdbjni-linux64.so 
   File format and CPU architecture: Elf, X86_64
   MODE64 (call)
   CMOV (cmovbe)
   SSE1 (movups)
   SSE2 (movdqa)
   BMI (tzcnt)
   BMI2 (shlx)
   Instruction set extensions used: BMI, BMI2, CMOV, MODE64, SSE1, SSE2
   CPU Generation: Haswell
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to