kerneltime commented on code in PR #6341:
URL: https://github.com/apache/ozone/pull/6341#discussion_r1531180296
##########
hadoop-hdds/rocks-native/pom.xml:
##########
@@ -235,6 +235,7 @@
<arg
line="${project.build.directory}/rocksdb/rocksdb-${rocksdb.version}"/>
</exec>
<exec executable="make"
dir="${project.build.directory}/rocksdb/rocksdb-${rocksdb.version}"
failonerror="true">
+ <arg line="PORTABLE=1"/>
Review Comment:
RocksDB does not use PORTABLE=0 so there is still some information missing
as to what is the build setup.
For now pushing this in makes sense as we are seeing crashes for missing
AVX4 but we still need to continue looking into what is the lowest common set
of instruction set the build should support or at least quantify the
performance impact. @swamirishi can you open a follow up Jira? Also, how was
this change tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
