sumitagrawl commented on code in PR #6305:
URL: https://github.com/apache/ozone/pull/6305#discussion_r1550057106
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -68,6 +69,7 @@ public ContainerBalancerSelectionCriteria(
this.replicationManager = replicationManager;
this.containerManager = containerManager;
selectedContainers = new HashSet<>();
+ excludeContainersDueToFailure = new HashSet<>();
Review Comment:
excludeContainersDueToFailure holds failure in the particular iteration, and
choosing the source again avoiding the container.
But in next iteration, when same source is re-considered, IMO, this list
also needs cleanup. This is required to be done in,
org.apache.hadoop.hdds.scm.container.balancer.ContainerBalancerTask#initializeIteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
