sumitagrawl commented on code in PR #6305:
URL: https://github.com/apache/ozone/pull/6305#discussion_r1556044087
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -563,6 +566,9 @@ private boolean processMoveSelection(DatanodeDetails source,
} catch (ContainerNotFoundException e) {
LOG.warn("Could not get container {} from Container Manager before " +
"starting a container move", containerID, e);
+ // add source back to queue as a different container can be selected in
next run.
+ findSourceStrategy.addBackSourceDataNode(source);
+
selectionCriteria.addToExcludeDueToFailContainers(moveSelection.getContainerID());
Review Comment:
If 2 different source have same container choosen to be moved to target to
reduce usages at source,
s1: c5.--> t5
s2: c5 --> t6
Now s1 for c5 had some failure, so this will avoid choosing c5 container for
s1 (as expected). But old logic where comment is given, it will also make c5
container not be choosed in another source s2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
