Tejaskriya commented on code in PR #6305:
URL: https://github.com/apache/ozone/pull/6305#discussion_r1552956831
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -563,6 +566,9 @@ private boolean processMoveSelection(DatanodeDetails source,
} catch (ContainerNotFoundException e) {
LOG.warn("Could not get container {} from Container Manager before " +
"starting a container move", containerID, e);
+ // add source back to queue as a different container can be selected in
next run.
+ findSourceStrategy.addBackSourceDataNode(source);
+
selectionCriteria.addToExcludeDueToFailContainers(moveSelection.getContainerID());
Review Comment:
Thanks for the review! I have created a Map of Dn and containers to be
excluded for that DN. Could you please take a look at the recent changes?
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -563,6 +566,9 @@ private boolean processMoveSelection(DatanodeDetails source,
} catch (ContainerNotFoundException e) {
LOG.warn("Could not get container {} from Container Manager before " +
"starting a container move", containerID, e);
+ // add source back to queue as a different container can be selected in
next run.
+ findSourceStrategy.addBackSourceDataNode(source);
+
selectionCriteria.addToExcludeDueToFailContainers(moveSelection.getContainerID());
Review Comment:
Thanks for the review! I have created a Map of DN and containers to be
excluded for that DN. Could you please take a look at the recent changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
