Tejaskriya commented on code in PR #6305:
URL: https://github.com/apache/ozone/pull/6305#discussion_r1552864793
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -68,6 +69,7 @@ public ContainerBalancerSelectionCriteria(
this.replicationManager = replicationManager;
this.containerManager = containerManager;
selectedContainers = new HashSet<>();
+ excludeContainersDueToFailure = new HashSet<>();
Review Comment:
In ContainerBalancerTask#initializeIteration, in the end we are creating a
new object for containerBalancerSelectionCriteria
```
selectionCriteria = new ContainerBalancerSelectionCriteria(config,
nodeManager, replicationManager, containerManager,
findSourceStrategy);
```
In the constructor, we are initializing `excludeContainersDueToFailure` to
empty set. That should take care of this
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -68,6 +69,7 @@ public ContainerBalancerSelectionCriteria(
this.replicationManager = replicationManager;
this.containerManager = containerManager;
selectedContainers = new HashSet<>();
+ excludeContainersDueToFailure = new HashSet<>();
Review Comment:
In ContainerBalancerTask#initializeIteration, in the end we are creating a
new object for containerBalancerSelectionCriteria
```
selectionCriteria = new ContainerBalancerSelectionCriteria(config,
nodeManager, replicationManager, containerManager,
findSourceStrategy);
```
In the constructor, we are initializing `excludeContainersDueToFailure` to
empty set. That should take care of this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
