siddhantsangwan commented on code in PR #6305:
URL: https://github.com/apache/ozone/pull/6305#discussion_r1566906407
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -862,13 +870,24 @@ private boolean moveContainer(DatanodeDetails source,
} catch (ContainerNotFoundException e) {
LOG.warn("Could not find Container {} for container move",
containerID, e);
+ // add source back to queue as a different container can be selected in
next run.
+ findSourceStrategy.addBackSourceDataNode(source);
+ // exclude the container which caused failure of move to avoid error in
next run.
+
selectionCriteria.addToExcludeDueToFailContainers(moveSelection.getContainerID());
metrics.incrementNumContainerMovesFailedInLatestIteration(1);
return false;
- } catch (NodeNotFoundException | TimeoutException |
- ContainerReplicaNotFoundException e) {
+ } catch (NodeNotFoundException | TimeoutException e) {
LOG.warn("Container move failed for container {}", containerID, e);
metrics.incrementNumContainerMovesFailedInLatestIteration(1);
return false;
+ } catch (ContainerReplicaNotFoundException e) {
+ LOG.warn("Container move failed for container {}", containerID, e);
+ metrics.incrementNumContainerMovesFailedInLatestIteration(1);
+ // add source back to queue for replica not found only
+ findSourceStrategy.addBackSourceDataNode(source);
+ // exclude the container whose replica caused failure of move to avoid
error in next run.
+
selectionCriteria.addToExcludeDueToFailContainers(moveSelection.getContainerID());
Review Comment:
I don't think we need to exclude this container as it's a replica related
error. Balancer should get the updated list of containers in a node from node
manager next time, so it's fine if we don't exclude it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
