mrdrivingduck commented on code in PR #189:
URL: https://github.com/apache/paimon-cpp/pull/189#discussion_r3754836640
##########
src/paimon/common/fs/object_store_file_system.cpp:
##########
@@ -388,6 +388,17 @@ Result<std::unique_ptr<InputStream>>
ObjectStoreFileSystem::Open(const std::stri
ToUri(object_path),
metadata.value().size);
}
+Result<std::unique_ptr<InputStream>> ObjectStoreFileSystem::Open(const
std::string& path,
+ int64_t
file_size) const {
+ PAIMON_RETURN_NOT_OK(ValidateValueNonNegative(file_size, "file size"));
+ PAIMON_ASSIGN_OR_RAISE(ObjectStorePath object_path, ParsePath(path));
+ if (object_path.key.empty()) {
Review Comment:
Done in file_system.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
