mrdrivingduck commented on PR #189: URL: https://github.com/apache/paimon-cpp/pull/189#issuecomment-5248368257
> One non-blocking follow-up, not for this PR: `DeletionVectorsIndexFile::ReadAllDeletionVectors` (`src/paimon/core/deletionvectors/deletion_vectors_index_file.cpp:53`) opens the DV index file by path while it already holds an `IndexFileMeta` that carries `FileSize()`, so it could reuse the same known-size path and drop one metadata request per index file. Would you mind leaving a `TODO` there, or filing it as a later PR? The other `Open` call sites I looked at (`deletion_vector.cpp`, `file_index_evaluator.cpp`) have no trusted total file size available today, so they would need extra metadata plumbing first and are not directly comparable. Done with a TODO for DV index. I think it does gain from the optimization in theory, but needs separated benchmark for verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
