lucasfang commented on PR #189: URL: https://github.com/apache/paimon-cpp/pull/189#issuecomment-5263094802
The benchmark case is convincing, and I don't want to hold up the optimization itself. My concern is only the signature, please consider Open(const FileStatus&) instead of Open(path, int64_t), and add a default implementation of FileStatus that callers can construct — see arrow::fs::FileSystem::OpenInputFile(const FileInfo&) for reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
