lucasfang commented on code in PR #189:
URL: https://github.com/apache/paimon-cpp/pull/189#discussion_r3771594984
##########
include/paimon/fs/file_system.h:
##########
@@ -178,6 +179,45 @@ class PAIMON_EXPORT FileStatus {
virtual int64_t GetModificationTime() const = 0;
};
+/// Default file status implementation for caller-supplied file metadata.
+///
+/// This class represents metadata that a caller already knows, without
requiring a file system
+/// metadata request. It is useful for operations that can use a trusted path
and file size.
+class PAIMON_EXPORT DefaultFileStatus final : public FileStatus {
Review Comment:
Could we make FileStatus a base class with a default implementation (using
virtual, but not pure virtual functions)? This would eliminate the need for a
separate DefaultFileStatus class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
