Akash3121 commented on code in PR #10161:
URL: https://github.com/apache/paimon/pull/10161#discussion_r4095842086
##########
paimon-python/pypaimon/common/merge_engine_dispatch.py:
##########
@@ -110,6 +110,7 @@ def build_merge_function(
value_field_names=(
list(value_field_names)
if value_field_names is not None else None),
+ ignore_delete=_ignore_delete_from_options(raw_options),
Review Comment:
` _ignore_delete_from_options` ultimately uses `_option_is_truthy` , which
recognizes only the string `"true"` . That conflicts with PyPaimon's canonical
`OptionsUtils.convert_to_boolean` / `CoreOptions.ignore_delete()` , where
`"1"` , `"yes"` , and `"on"` are also true. Consequently, a valid table
option such as `ignore-delete=yes` now passes the unsupported-option guard
but constructs this merge function with ignore_delete=False ; the first
retract then raises `NotImplementedError` . Please resolve this through
`CoreOptions.ignore_delete()` or `OptionsUtils.convert_to_boolean` rather
than maintaining a second boolean parser, and test every canonical true/false
spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
