jackylee-ch commented on code in PR #10161:
URL: https://github.com/apache/paimon/pull/10161#discussion_r4111426340
##########
paimon-python/pypaimon/common/merge_engine_dispatch.py:
##########
@@ -110,6 +110,7 @@ def build_merge_function(
value_field_names=(
list(value_field_names)
if value_field_names is not None else None),
+ ignore_delete=_ignore_delete_from_options(raw_options),
Review Comment:
Good catch — fixed in e4db05d54. `_option_is_truthy` now delegates to
`OptionsUtils.convert_to_boolean` (the parser behind
`CoreOptions.ignore_delete()`), so `ignore-delete=yes` / `1` / `on` are honored
consistently instead of being silently downgraded to `False`. The dispatch
tests were updated to cover those spellings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
