jackylee-ch commented on PR #10161: URL: https://github.com/apache/paimon/pull/10161#issuecomment-5826602960
Thanks @Akash3121, fixed in 7a829d960. `_option_is_truthy` now delegates to `OptionsUtils.convert_to_boolean` (`CoreOptions.ignore_delete()`'s parser) instead of a second strict parser, so `true`/`1`/`yes`/`on` are true and `false`/`0`/`no`/`off` false; an unrecognized spelling raises. This covers both the ignore-delete wiring (`ignore-delete=yes` now builds `ignore_delete=True`, skipping retracts instead of raising) and the unsupported-option guard. Tests exercise every canonical spelling for both, plus that a canonical-true `remove-record-on-delete` stays flagged. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
