JingsongLi commented on PR #10176: URL: https://github.com/apache/paimon/pull/10176#issuecomment-5831510429
Reviewed 1ace8f2. The FileStoreTable fallback has end-to-end value for REST servers without the partition endpoint, and the extraction preserves the filesystem-catalog path. I found one compatibility gap to address before claiming Java parity: **[P2] The fallback guard rejects tables Java permits.** In `RESTCatalog.list_partitions_paged`, `if not isinstance(table, FileStoreTable): raise` rejects every format/object/other table. Java `RESTCatalog#listPartitionsPaged` re-raises only when `hasCatalogManagedPartitions(table)` is true, which specifically means a `FormatTable` with a non-null partition manager; an unmanaged format table falls back to its scan. Thus `table list-partitions` still fails on an unmanaged format table when the REST endpoint is absent. The extracted helper only understands Paimon manifests, so please either implement the scan-based fallback for those table types (with an unmanaged-format test and a managed-format negative test), or explicitly narrow the advertised scope and explain the Java behavior difference. Validation: 7 REST-server tests in `RESTListPartitionsFallbackTest` passed, including the new manifest/statistics and pagination cases; the two filesystem-catalog pagination/pattern tests passed; `git diff --check` passed and CI run 36102903876 is green. The first local REST test run could not bind a localhost port inside the sandbox; rerunning with that permission passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
