LuciferYang opened a new pull request, #10205:
URL: https://github.com/apache/paimon/pull/10205

   ### Purpose
   
   `FallbackReadFileStoreTable.rewriteOtherOptions` converts a scan snapshot 
id, or a numeric `scan.version`, on the main branch into the fallback branch's 
id by eagerly loading the main-branch snapshot. When that id does not exist on 
the main branch (for example after the main branch was rolled back, or when the 
id belongs to the fallback branch), the eager `snapshotManager().snapshot(id)` 
fails and option merging fails outright.
   
   Option merging must not resolve time travel eagerly. `copyWithoutTimeTravel` 
exists for exactly that, a plain table defers the id to the scan, and engines 
merge dynamic options before applying time travel.
   
   This converts the id only when the snapshot exists on the main branch. 
Otherwise it leaves the option unchanged, so the scan of whichever branch 
serves the read reports the missing snapshot with its own context, and a 
numeric version is not silently dropped from the merged options.
   
   ### Tests
   
   `FallbackReadFileStoreTableTest` gains cases for a main-branch snapshot id 
that does not exist on the main branch, asserting the option is left 
unconverted and a numeric `scan.version` is preserved rather than dropped.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to