LuciferYang commented on PR #10205: URL: https://github.com/apache/paimon/pull/10205#issuecomment-5852790812
Closing this after a closer look. In fallback-branch mode, a scan snapshot id that is missing on the main branch fails the read either way. This change only moved that failure from `copy()` to the scan, arguably with a less clear error, so there is no confirmed improvement there. In primary-branch mode, leaving the id unconverted can let the read fall through to the primary branch's same-numbered snapshot when the current branch's validation is skipped, turning a safe early failure into a possibly-silent read of a different snapshot. Whether that is correct depends on how the id should be numbered in primary mode, which is not well defined today, and the change has no coverage for it. That is a semantic/design question better settled on its own than as part of this change, so I would rather not ship it here. Closing; can revisit if we decide the primary-mode numbering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
