LuciferYang opened a new pull request, #10210:
URL: https://github.com/apache/paimon/pull/10210

   ### Purpose
   
   When an incremental-between-timestamp diff query has a start timestamp that 
predates every retained snapshot, the true "before" state is empty or has been 
expired, so every row live at the end snapshot belongs in the diff.
   
   The code already returned a full static read at the end snapshot when the 
earliest retained snapshot was the first snapshot, but after snapshot expiry 
removed the first snapshot it instead diffed from the earliest retained 
snapshot, silently dropping rows created at or before that snapshot that were 
still live.
   
   This returns the static full end read whenever no snapshot is at or before 
the start timestamp, independent of which snapshot is currently the earliest 
retained one.
   
   ### Tests
   
   Adds 
`IncrementalTimeStampTableTest.testDiffFromBeforeEarliestRetainedSnapshot`, 
which writes three snapshots, expires the first so the earliest retained 
snapshot is no longer snapshot 1, runs a diff from a start timestamp before all 
snapshots, and asserts all three live rows are returned. This case fails on the 
current code and passes with the fix.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to