JingsongLi commented on PR #963: URL: https://github.com/apache/paimon-rust/pull/963#issuecomment-5935604587
Requirement fit: SUPPORTED. Implementation: FINDINGS. [P2] Resolve the authoritative catalog snapshot when building full-text indexes (`crates/paimon/src/table/full_text_index_build_builder.rs:117-120`). Creating a bare SnapshotManager discards the table's RESTEnv. Normal reads and commit validation use the catalog snapshot, but this builder plans against the filesystem snapshot. A real HTTP-backed probe with valid physical Parquet/manifests, filesystem snapshot 1 and catalog snapshot 7 reads both rows normally from snapshot 7, then the new build fails with "expected latest snapshot 1, got 7" although no concurrent commit occurred. REST-managed tables need not have the latest snapshot JSON in their file directory. Use self.table.snapshot_manager() consistently with reads and commit validation. Existing other builders share the pattern; this finding is scoped to the new full-text path. A temporary one-line manager change makes the complete build/publish probe pass. Validation at cafb325cc6e6b8930ae938e280aa0b6478164d30: enabled fulltext and ran all 103 matching core tests plus 34 original DataFusion procedure tests, including actual create -> search -> no-op rebuild -> drop. An additional real partitioned-table create/search/incremental/drop SQL probe passes. The REST probe fails on the head and passes with only the manager correction. Independent metadata/range/drop/concurrency and native-writer/upload checks found no further issue. Current-main merge-tree is clean and all 14 head CI checks passed; those CI jobs do not run this fulltext SQL feature path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
