JingsongLi commented on code in PR #963:
URL: https://github.com/apache/paimon-rust/pull/963#discussion_r4177314683
##########
crates/paimon/src/table/global_index_types.rs:
##########
@@ -63,6 +66,9 @@ pub fn normalize_global_index_type_for_drop(index_type: &str)
-> Option<&'static
if let Some(queryable) = normalize_queryable_global_index_type(index_type)
{
return Some(queryable);
}
+ if index_type.eq_ignore_ascii_case(FULL_TEXT_GLOBAL_INDEX_TYPE) {
Review Comment:
[P2] Use the catalog snapshot for the newly enabled full-text DROP
This enables full-text in GlobalIndexDropBuilder, but execute() still
constructs a bare SnapshotManager at global_index_drop_builder.rs:94. On a
REST-managed table with physical snapshot 1 and authoritative catalog snapshot
7, the corrected full-text builder successfully publishes catalog snapshot 8
and search returns the matching row. The new full-text DROP then returns 0,
publishes nothing, and the row remains searchable, because physical snapshot 1
has no index manifest. A real HTTP/Parquet/index probe fails on this head with
DROP returned 0; catalog snapshot=8; search after DROP=[RowRange { from: 0, to:
0 }]. Use self.table.snapshot_manager() for drop as for the new build and
normal reads, and cover build -> search -> drop through REST.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
