zhuxiangyi commented on code in PR #963:
URL: https://github.com/apache/paimon-rust/pull/963#discussion_r4178227659
##########
crates/paimon/src/table/global_index_types.rs:
##########
@@ -63,6 +66,9 @@ pub fn normalize_global_index_type_for_drop(index_type: &str)
-> Option<&'static
if let Some(queryable) = normalize_queryable_global_index_type(index_type)
{
return Some(queryable);
}
+ if index_type.eq_ignore_ascii_case(FULL_TEXT_GLOBAL_INDEX_TYPE) {
Review Comment:
Fixed in a7222a3. `GlobalIndexDropBuilder` now uses
`self.table.snapshot_manager()`, like the full-text build and normal reads.
`test_build_search_and_drop_through_the_catalog_snapshot` extends the REST
test. With file system snapshot 1 and catalog snapshot 7, the build publishes
snapshot 8, and search finds the row. The drop then returns 1 and publishes
snapshot 9 through the catalog, and search finds nothing. On the old code it
fails at the drop (`left: 0, right: 1`), matching your probe.
While rebasing onto main 8c3527b, I also adapted the test to the new
`RESTEnv::new` signature (`FileIOCacheContext`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
