JingsongLi commented on code in PR #1448:
URL: https://github.com/apache/paimon-rust/pull/1448#discussion_r4623662820


##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -269,7 +269,11 @@ pub(crate) fn build_table_definition(table: &Table) -> 
DFResult<String> {
         ddl.push(')');
     }
 
-    let mut options: Vec<_> = schema.options().iter().collect();
+    let mut options: Vec<_> = schema
+        .options()
+        .iter()
+        .filter(|(key, _)| key.as_str() != "internal.table-creation-id")

Review Comment:
   Do we need this?



##########
crates/paimon/src/catalog/mod.rs:
##########
@@ -44,6 +44,8 @@ pub use rest::*;
 use serde::{Deserialize, Serialize};
 pub use view::*;
 
+pub(crate) const TABLE_CREATION_ID: &str = "internal.table-creation-id";

Review Comment:
   Ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to