JingsongLi commented on code in PR #1448:
URL: https://github.com/apache/paimon-rust/pull/1448#discussion_r4643281940
##########
crates/paimon/src/catalog/filesystem.rs:
##########
@@ -463,11 +464,23 @@ impl Catalog for FileSystemCatalog {
});
}
- // todo: consider with lock
if !table_exists {
- self.file_io.mkdirs(&table_path).await?;
+ self.file_io
+ .mkdirs(&self.schema_dir_path(&table_path))
+ .await?;
let table_schema = TableSchema::new(0, &creation);
- self.save_table_schema(&table_path, &table_schema).await?;
+ let created = self
+ .file_io
+ .write_atomic_if_not_exists(
Review Comment:
**[P1] Preserve ordinary CREATE on storage without conditional publication**
Every `FileSystemCatalog::create_table` now requires a conditional rename or
an approved atomic whole-object write. Locked OpenDAL HDFS-native 0.59.5
provides ordinary write and rename only. A user who registers existing HDFS
Parquet files as a Format Table now gets `IoUnsupported` publishing
`schema/schema-0`. Format Table reads and commits do not require snapshot
publication, so this is an existing production path affected by the CTAS change.
A catalog-level test using a real filesystem operator with those conditional
capabilities disabled reproduced the failure after successful database
creation. Please scope exclusive creation to CTAS, or provide a safe
publication implementation for the affected backends before requiring it for
ordinary CREATE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]