SteNicholas commented on PR #1448:
URL: https://github.com/apache/paimon-rust/pull/1448#issuecomment-7073142126

   @JingsongLi, thanks for running the CTAS and DataFusion suites. I fixed the 
ordinary `CREATE TABLE` regression in 178d0082. Filesystem CTAS requires atomic 
publication of the initial schema. Ordinary table creation can use a plain 
write on HDFS-native and other backends that lack conditional publication. 
[Original 
review](https://github.com/apache/paimon-rust/pull/1448#pullrequestreview-5993791552)
   
   All 19 CTAS tests passed on this revision. The catalog regression test 
disables conditional write and rename on a local filesystem operator, registers 
an existing Parquet file as a Format Table, and reads its rows back. 
[Regression 
test](https://github.com/apache/paimon-rust/blob/178d0082b1dc803e91d93dbe52a41c0689f64f64/crates/paimon/src/catalog/filesystem.rs#L1828-L1906)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to