SteNicholas commented on PR #1448: URL: https://github.com/apache/paimon-rust/pull/1448#issuecomment-7079936333
Thanks for the review, @JingsongLi. All four fixes are in `690b10ea`. I compared it with `da3a9470`, the commit linked in the inline replies, and `git range-diff` confirms the rebase preserved the patch. [Original review](https://github.com/apache/paimon-rust/pull/1448#pullrequestreview-6011028452) · [Current commit](https://github.com/apache/paimon-rust/pull/1448/commits/690b10ea87d45a0ddf469ba4a8436d5a96bbcb99) - On the built-in S3 backend, a first-attempt HTTP 412 on the conditional `schema-0` write is a definite conflict. A 412 after a retry returns an unknown publication outcome, which CTAS propagates even with `IF NOT EXISTS`. [S3 regression](https://github.com/apache/paimon-rust/blob/690b10ea87d45a0ddf469ba4a8436d5a96bbcb99/crates/paimon/src/io/storage_s3.rs#L554-L613) - Time-travel `PREPARE` plans against the captured state and registers the statement in the caller’s session. The regression runs `EXECUTE historical(3)` in that session and checks that it returns `6`. [Prepared-statement regression](https://github.com/apache/paimon-rust/blob/690b10ea87d45a0ddf469ba4a8436d5a96bbcb99/crates/integrations/datafusion/tests/time_travel_schema_tests.rs#L195-L226) - The parser consumes the full target name before looking for the query’s `AS`. Ordinary `CREATE TABLE mydb.as` keeps `dt` as its partition key, and CTAS into `paimon.default.as` keeps `id` even when the query returns no rows. [CREATE regression](https://github.com/apache/paimon-rust/blob/690b10ea87d45a0ddf469ba4a8436d5a96bbcb99/crates/integrations/datafusion/src/sql_context.rs#L9381-L9396) · [CTAS regression](https://github.com/apache/paimon-rust/blob/690b10ea87d45a0ddf469ba4a8436d5a96bbcb99/crates/integrations/datafusion/tests/create_table_as.rs#L155-L183) - Unaliased scans of different snapshots get distinct bindings when their qualifiers collide, and explicit aliases retain their meaning. The regression checks that `JOIN ... USING (id)` finds three shared IDs and a right anti join finds the two IDs added in version 2. [Snapshot-join regression](https://github.com/apache/paimon-rust/blob/690b10ea87d45a0ddf469ba4a8436d5a96bbcb99/crates/integrations/datafusion/tests/time_travel_schema_tests.rs#L229-L299) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
