rdblue commented on code in PR #460: URL: https://github.com/apache/parquet-format/pull/460#discussion_r1809442377
########## VariantEncoding.md: ########## @@ -42,7 +42,7 @@ This document describes the Variant Binary Encoding scheme. [VariantShredding.md](VariantShredding.md) describes the details of the Variant shredding scheme. # Variant in Parquet -A Variant value in Parquet is represented by a group with 2 fields, named `value` and `metadata`. +A Variant value in Parquet is represented by a group annotated with `VARIANT`, with 2 fields, named `value` and `metadata`. Review Comment: Looks like we need to deduplicate changes between this one and #461. How about leaving VariantEncoding.md and VariantShredding.md as they are in this PR and letting #461 update them? Then this can be used to update LogicalTypes.md and the thrift definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
